Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update frontend Dockerfile #48

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

nas-tabchiche
Copy link
Contributor

  • Update node image to node 21
  • Copy project.inlang before running npm ci

@nas-tabchiche nas-tabchiche marked this pull request as ready for review February 14, 2024 11:25
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

- Update node image to node 21
- Copy project.inlang before running npm ci
Somehow ./db/ did not gitignore db/django_secret_key
@nas-tabchiche nas-tabchiche force-pushed the fix/frontend-dockerfile branch from a0adcb9 to 17d20a9 Compare February 14, 2024 11:44
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit ccbdc84 into main Feb 14, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@nas-tabchiche nas-tabchiche deleted the fix/frontend-dockerfile branch February 15, 2024 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants